Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploaded videos don't load on Safari iOS #1569

Closed
1 task done
ekzyis opened this issue Nov 10, 2024 · 2 comments
Closed
1 task done

Uploaded videos don't load on Safari iOS #1569

ekzyis opened this issue Nov 10, 2024 · 2 comments

Comments

@ekzyis
Copy link
Member

ekzyis commented Nov 10, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

See title

Screenshots

Safari PWA on iOS:

signal-2024-11-10-162050

Brave on Desktop:

2024-11-10-162006_1920x1080_scrot

Steps To Reproduce

  1. Upload video from other device because of Can't use "record video" as upload option on Safari iOS #1568
  2. View item on Safari iOS

(not confirmed)

Expected behavior

Video is visible on Safari iOS

Logs

No response

Device information

No response

Additional context

No response

@ekzyis ekzyis added the bug label Nov 10, 2024
@huumn
Copy link
Member

huumn commented Nov 10, 2024

It's likely a CSS issue. Safari is uniquely glitchy when it comes to video.

@Soxasora
Copy link
Contributor

It's likely a CSS issue. Safari is uniquely glitchy when it comes to video.

I'm exploring also this issue, you're right it is indeed a CSS issue, specifically text.module.css at line 187

.p:has(> .mediaContainer) .mediaContainer
{
    display: flex;
    width: min-content; /* Safari doesn't like this */
    max-width: 100%;
}

This actually works on Safari for Mac
Safari loading the video

But on Safari for iOS (or PWA) the story is much different, it tries to render all the possible resolutions of the image that actually is a video, in fact media-or-link.js tries to load the video as img before creating a video element that only then will be populated with the video data.
I'm still investigating, for now I'm battling hydration errors as testing PWAs is its own hell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants