Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back/forward browser navigation for carousel images #1508

Open
SouthKoreaLN opened this issue Oct 23, 2024 · 3 comments · May be fixed by #1601
Open

Back/forward browser navigation for carousel images #1508

SouthKoreaLN opened this issue Oct 23, 2024 · 3 comments · May be fixed by #1601
Labels
difficulty:easy enhancement improvements to existing features multimedia

Comments

@SouthKoreaLN
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When I am looking at an embedded picture (like in, I clicked on it, and it's filling the screen), I intuitively click "back" on my android phone to get back to the post where this picture was posted. However, because of the current choice in UX, it brings me back to the main feed instead.

Describe the solution you'd like
Just bring me back to the post, not the feed.

Describe alternatives you've considered
I could probably break the habit and just click away from the picture to make it go away and stay in the post. That's how it currently works.

@SouthKoreaLN SouthKoreaLN added the feature new product features that weren't there before label Oct 23, 2024
@huumn
Copy link
Member

huumn commented Oct 23, 2024

This is something we can do. We'll just need to push a new url on the browser history stack shallowly like:

router.push({ router.pathname, { query: { imageId: $num } }, { shallow: true })

@huumn huumn changed the title Embedded picture UX improvment Back/forward browser navigation for carousel images Oct 23, 2024
@huumn huumn added enhancement improvements to existing features multimedia difficulty:easy and removed feature new product features that weren't there before labels Oct 23, 2024
@aegroto
Copy link
Contributor

aegroto commented Nov 17, 2024

Just a quick question to understand if I have understood this issue correctly, doesn't this happen on desktop as well if you go the previous page on any browser? Or is it related to some mobile-specific actions?

@ekzyis
Copy link
Member

ekzyis commented Nov 17, 2024

You are right, this also happens on desktop

@aegroto aegroto linked a pull request Nov 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:easy enhancement improvements to existing features multimedia
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants