Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures on paid action retry flicker, doesn’t show qr #1500

Open
huumn opened this issue Oct 19, 2024 · 2 comments
Open

Failures on paid action retry flicker, doesn’t show qr #1500

huumn opened this issue Oct 19, 2024 · 2 comments

Comments

@huumn
Copy link
Member

huumn commented Oct 19, 2024

For whatever reason my sending wallet is failing on the Wi-Fi I’m using and when retrying I can’t fallback to a qr.

@huumn huumn changed the title Failures on paid action retry flicker, don’t show qr Failures on paid action retry flicker, doesn’t show qr Oct 19, 2024
@ekzyis ekzyis added this to the Nov 5 milestone Oct 23, 2024
@riccardobl
Copy link
Member

riccardobl commented Nov 18, 2024

This is caused by the wallet failing too slowly and the qr code not showing due to the 1000 ms timeout here:
https://github.com/stackernews/stacker.news/blob/master/components/use-paid-mutation.js#L40

Even if we increase the timeout, there might be multiple wallets failing, so it will be hard to have a reliable behavior.

IMO a possible solution is to use alwaysShowQROnFailure when pressing the retry button and show a modal that lets the user know the payment is happening, with a button to cancel, so we avoid the 'qr code showing up during the navigation' issue.

@huumn
Copy link
Member Author

huumn commented Nov 18, 2024

If there are attached wallets, I think we'll want to retry in the background as opposed to a QR popping up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants