Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exporter: memory leak in CommitteeObserver.postConsensusContainer #1857

Open
y0sher opened this issue Nov 19, 2024 · 0 comments · May be fixed by #1859
Open

exporter: memory leak in CommitteeObserver.postConsensusContainer #1857

y0sher opened this issue Nov 19, 2024 · 0 comments · May be fixed by #1859
Labels
bug Something isn't working

Comments

@y0sher
Copy link
Contributor

y0sher commented Nov 19, 2024

Description

It seems that postConsensusContainer map is never cleaned and always keeps growing causing a memory leak in exporter.

NOTE: it also looks like we are saving all the post consensus sigs under validator index without any notion of the slot?

Possible solutions

Change the mapping to be per-slot and remove on slots on newer slots arrival.
@y0sher y0sher added the bug Something isn't working label Nov 19, 2024
@y0sher y0sher linked a pull request Nov 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(CommitteeObserver): post consensus mem leak ssvlabs/ssv
1 participant
@y0sher