Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip current session and cookie value overriding from identity resolver #69

Open
ollieread opened this issue Nov 18, 2024 · 0 comments
Open
Assignees
Labels
status: planning The issue is being planned for the future type: refactor Refactoring of code

Comments

@ollieread
Copy link
Member

Currently, the identity resolvers that deal with the URL or other parts of a request that would affect the session or a cookie, set those values through the OverridesCookieSettings trait in the ServiceOverride::setup() method.

This is less than ideal, and should ideally be flipped. There needs to be a mechanism by which service overrides can get relevant details from identity resolvers, without identity resolvers having to know of the service overrides.

Perhaps interfaces or attributes?

@ollieread ollieread self-assigned this Nov 18, 2024
@ollieread ollieread converted this from a draft issue Nov 18, 2024
@ollieread ollieread added type: refactor Refactoring of code status: planning The issue is being planned for the future labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: planning The issue is being planned for the future type: refactor Refactoring of code
Projects
Status: Backlog
Development

No branches or pull requests

1 participant