Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function that accepts StepExecution parameter to Partitioner API #4716

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wesley-94
Copy link

Add function that accepts StepExecution parameter to Partitioner API

@pivotal-cla
Copy link

@wesley-94 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@injae-kim
Copy link
Contributor

Closes: #4670

@pivotal-cla
Copy link

@wesley-94 Thank you for signing the Contributor License Agreement!

@@ -30,7 +31,7 @@
* @author Taeik Lim
* @since 2.0
*/
@FunctionalInterface
// @FunctionalInterface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove //? (maybe we should remove @FunctionalInterface cause we have 2 method

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified it as you reviewed. Thank you!

@djechelon
Copy link

Thanks so much for this PR.
But this looks incomplete.

  1. You have to amend the caller, which I don't see in the PR. The caller must point at the new method passing the StepExecution
  2. I don't like the idea of having non-default partition(int) because what we want is both to not create regressions, but to encourage users transition to the new API. There is no other possibility than making both methods default IMO

@wesley-94
Copy link
Author

Thanks for your answer.
But ‘No target method found’ message was found at @FunctionalInterface when using ‘default’ keyword in both of methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants