[core] extend color.ini functionality to PIP windows

[invisiblefmx]

📝 Provide a description of the new feature

Spotify for Windows (64 Bit)
1.2.31.1205.g4d59ad7c
Spicetify v2.31.3

Since there is a new pip player activated in the new spotify release it would be great if themes had an easy way to change its colors to fit the theme. Dark grey with black songtitle and black buttons just looks bad and is not very readable.

➕ Additional Information

No response

[rxri]

I cannot enable it for some reason so I cannot work on it atm

[rxri]

Dependent on encore variable colors, not suitable to implement in v2

[ohitstom]

Dependent on encore variable colors, not suitable to implement in v2

it looks like the only issue is that there is no existence of colors.css on created instances (or helpers, etc) , also the way to enable PIP is by running on the chrome runtime not alloy and by enabling the exp feature!

so i guess we just need to modify the index for these instances to add these, will open a PR tonight

[ohitstom]

having a quick look it seems no .html file exists and its done internally somewhere, to save use from webpack headache and stuff maybe we can just append the :root colors directly at the top of "pip-mini-player.css" during the patching stage? how does that sound to you @rxri

[rxri]

having a quick look it seems no .html file exists and its done internally somewhere, to save use from webpack headache and stuff maybe we can just append the :root colors directly at the top of "pip-mini-player.css" during the patching stage? how does that sound to you @rxri

It's not worth it. v3 is on its way and will be released in ~2 months. This PiP is not released to everyone so I'm not going to merge it just yet, and it also requires chrome runtime which is rolling out I guess?

[ohitstom]

having a quick look it seems no .html file exists and its done internally somewhere, to save use from webpack headache and stuff maybe we can just append the :root colors directly at the top of "pip-mini-player.css" during the patching stage? how does that sound to you @rxri

It's not worth it. v3 is on its way and will be released in ~2 months. This PiP is not released to everyone so I'm not going to merge it just yet, and it also requires chrome runtime which is rolling out I guess?

may i ask what v3 entails? im not seeing branch, issue, or pr - just interested
unless you mean spotify

[rxri]

https://github.com/delusoire/bespoke

[ohitstom]

https://github.com/delusoire/bespoke

not sure how to feel about this, gonna turn everything upside down lol! good luck though