Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instancing regression #314

Closed
oguzhankoral opened this issue Nov 29, 2023 · 0 comments · Fixed by #315
Closed

Instancing regression #314

oguzhankoral opened this issue Nov 29, 2023 · 0 comments · Fixed by #315
Assignees
@oguzhankoral
Labels
regression Implementations effected other parts

Comments

@oguzhankoral
Copy link
Member

Definition created always regardless it is same or not. After investions figured it out that children change detection was causing the wrong boolean return at some cases.
@oguzhankoral oguzhankoral added the regression Implementations effected other parts label Nov 29, 2023
@oguzhankoral oguzhankoral self-assigned this Nov 29, 2023
@oguzhankoral oguzhankoral linked a pull request Nov 29, 2023 that will close this issue
Fix (Instancing): correct id of definition for speckle entity #315
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oguzhankoral oguzhankoral

Labels
regression Implementations effected other parts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix (Instancing): correct id of definition for speckle entity specklesystems/speckle-sketchup
1 participant
@oguzhankoral