feat(core/seo): support adding git revision in meta #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to set a git revision of the source used to the generated content. Bikeshed does this, but with 'document-revision' as a meta name - that said, 'revision' is the name recommended in https://wiki.whatwg.org/wiki/MetaExtensions Typically, this would be set when generating the static HTML (a possible separate improvement to spec-prod)
dontcallmedom
force-pushed
the
set-git-revision
branch
from
839f104
to
a8e08d0
Compare
dontcallmedom
referenced
this pull request
in w3c/spec-prod
Oct 13, 2023
Useful if https://github.com/w3c/respec/pull/4561 gets merged
dontcallmedom
referenced
this pull request
in w3c/spec-prod
Oct 13, 2023
Useful if https://github.com/w3c/respec/pull/4561 gets merged
dontcallmedom
referenced
this pull request
in w3c/spec-prod
Oct 13, 2023
Useful if https://github.com/w3c/respec/pull/4561 gets merged
dontcallmedom
referenced
this pull request
in w3c/spec-prod
Oct 13, 2023
Useful if https://github.com/w3c/respec/pull/4561 gets merged
dontcallmedom
referenced
this pull request
in w3c/spec-prod
Oct 13, 2023
Useful if https://github.com/w3c/respec/pull/4561 gets merged
dontcallmedom
referenced
this pull request
in w3c/spec-prod
Oct 16, 2023
Useful if https://github.com/w3c/respec/pull/4561 gets merged
dontcallmedom
referenced
this pull request
in w3c/spec-prod
Oct 16, 2023
Useful if https://github.com/w3c/respec/pull/4561 gets merged
dontcallmedom
referenced
this pull request
in w3c/spec-prod
Oct 16, 2023
Useful if https://github.com/w3c/respec/pull/4561 gets merged
dontcallmedom
referenced
this pull request
in w3c/spec-prod
Oct 16, 2023
Useful if https://github.com/w3c/respec/pull/4561 gets merged
sidvishnoi
approved these changes
Oct 16, 2023
sidvishnoi
changed the title
sidvishnoi
reviewed
Oct 16, 2023
src/w3c/seo.js
Outdated
| @@ -33,6 +33,18 @@ export const requiresCanonicalLink = new Set([ | |||
| ]); | |||
|
|
|||
| export async function run(conf) { | |||
| if (conf.gitRevision) { | |||
There was a problem hiding this comment.
I wonder if it should be a part of conf.github though - but that can mean we lose setting conf.github as string. Maybe better as gitRevision.
|
@dontcallmedom I'll move this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to set a git revision of the source used to the generated content. Bikeshed does this, but with 'document-revision' as a meta name - that said, 'revision' is the name recommended in https://wiki.whatwg.org/wiki/MetaExtensions
Typically, this would be set when generating the static HTML (a possible separate improvement to spec-prod)