Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues #352 and #369, and PR #432.
The
setParsableMimeTypes
option does not actually prevent a crawl of a URL, it only prevents URLs that originate from that page from being crawled.If
executeJavascript
is enabled in tandem, thesetParsableMimeTypes
option becomes completely broken; as it turns out, the method with which mime types are ignored conflicts with Browsershot's JavaScript execution, since it overwrites the$body
variable:This PR prevents pages with non-parsable mime types from being crawled completely, edits the test for mime types to be more representative of what this feature should accomplish, and adds an additional test to validate that the issue is fixed when executing JS, as well.