ci: Extend golangci-lint configuration and fix errors

.gitignore

@@ -19,3 +19,4 @@ key.*
 completions
 
 *.csv
+.idea

.golangci.yml

@@ -0,0 +1,101 @@
+linters-settings:
+  depguard:
+    rules:
+      main:
+        deny:
+          - pkg: "io/ioutil"
+            # https://go.dev/doc/go1.16#ioutil
+            desc:  io/ioutil package has been deprecated.
+  dupl:
+    threshold: 100
+  funlen:
+    lines: 100
+    statements: 50
+  gci:
+    sections:
+      - standard
+      - default
+      - prefix(github.com/spacelift-io/backend)
+  goconst:
+    min-len: 2
+    min-occurrences: 2
+  gocritic:
+    enabled-tags:
+      - diagnostic
+      - performance
+    disabled-checks:
+      - ifElseChain
+      - wrapperFunc
+      - hugeParam
+      - rangeValCopy
+      - appendCombine
+      - commentedOutCode
+      - sloppyReassign
+      - filepathJoin
+      - evalOrder
+      - equalFold
+      - returnAfterHttpError
+      - preferStringWriter
+      - sprintfQuotedString
+      - preferFprint
+  gofmt:
+    simplify: true
+  goimports:
+    local-prefixes: github.com/spacelift-io/backend
+  govet:
+    check-shadowing: false
+    enable:
+      - nilness
+  nolintlint:
+    require-explanation: false # don't require an explanation for nolint directives
+    require-specific: false # don't require nolint directives to be specific about which linter is being skipped
+  revive:
+    rules:
+      - name: blank-imports
+      - name: context-as-argument
+      - name: context-keys-type
+      - name: dot-imports
+      - name: error-return
+      - name: increment-decrement
+      - name: var-declaration
+      - name: package-comments
+      - name: range
+      - name: time-naming
+      - name: errorf
+      - name: unreachable-code
+      - name: redefines-builtin-id
+  staticcheck:
+    checks: [ "all", "-SA1019"]
+
+  errorlint:
+    errorf: false
+    errorf-multi: false
+    asserts: false
+    comparison: true
+
+linters:
+  disable-all: true
+  enable:
+    - asasalint
+    - bodyclose
+    - depguard
+    - errorlint
+    - gci
+    - gocheckcompilerdirectives
+    - gocritic
+    - gofmt
+    - goimports
+    - goprintffuncname
+    - gosec
+    - gosimple
+    - govet
+    - ineffassign
+    - makezero
+    - noctx
+    - nolintlint
+    - staticcheck
+    - revive
+    - typecheck
+    - unconvert
+    - wastedassign
+    - unparam

browserauth/browserauth.go

@@ -212,13 +212,13 @@ func (h *Handler) extractToken(r *http.Request) error {
 	}
 
 	// Decrypt the token AES key using our private key
-	key, err := rsa.DecryptOAEP(sha512.New(), rand.Reader, h.key, []byte(encKey), nil)
+	key, err := rsa.DecryptOAEP(sha512.New(), rand.Reader, h.key, encKey, nil)
 	if err != nil {
 		return errors.Wrap(err, "could not decrypt key")
 	}
 
 	// Decrypt the token using the decrypted AES key
-	jwt, err := internal.DecryptAES(key, []byte(encToken))
+	jwt, err := internal.DecryptAES(key, encToken)
 	if err != nil {
 		return errors.Wrap(err, "could not decrypt session token")
 	}

client/client.go

@@ -8,9 +8,8 @@ import (
 	"strings"
 
 	"github.com/shurcooL/graphql"
-	"golang.org/x/oauth2"
-
 	"github.com/spacelift-io/spacectl/client/session"
+	"golang.org/x/oauth2"
 )
 
 type client struct {

client/session/from_environment.go

@@ -17,11 +17,11 @@ const (
 
 	// EnvSpaceliftAPIKeyEndpoint represents the name of the environment variable
 	// pointing to the Spacelift API endpoint.
-	EnvSpaceliftAPIKeyEndpoint = "SPACELIFT_API_KEY_ENDPOINT"
+	EnvSpaceliftAPIKeyEndpoint = "SPACELIFT_API_KEY_ENDPOINT" //nolint: gosec
 
 	// EnvSpaceliftAPIKeyID represents the name of the environment variable
 	// pointing to the Spacelift API key ID.
-	EnvSpaceliftAPIKeyID = "SPACELIFT_API_KEY_ID"
+	EnvSpaceliftAPIKeyID = "SPACELIFT_API_KEY_ID" //nolint: gosec
 
 	// EnvSpaceliftAPIKeySecret represents the name of the environment variable
 	// pointing to the Spacelift API key secret.