Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate installation and initialization in pyenv_user_install resource #59

Open
tilne opened this issue Feb 5, 2020 · 6 comments
Open
Assignees
Labels
hacktoberfest An issue highlighted for the digital ocean Hacktoberfest Event Help Wanted Assistance is required to resolve this issue

Comments

@tilne
Copy link

tilne commented Feb 5, 2020

:person_frowning: Problem Statement

The installation and activation of pyenv_user_install resources is currently inseparable. This makes it impossible to create an environment without also activating it.

❔ Possible Solution

The pyenv_user_install resource should have an attribute (something along the lines of activate?) that can be used to prevent activation of the newly created resource.

@xorima
Copy link
Contributor

xorima commented Feb 5, 2020

Could you PR this new property in with the default being to keep existing behaviour,

At some point in future we should split them out but that is more work

@tilne
Copy link
Author

tilne commented Feb 5, 2020

@xorima sure.

@tilne
Copy link
Author

tilne commented Jun 3, 2020

Are you still open to the idea of this change? How long would it take from submitting a PR to releasing a new version containing the change?

@xorima
Copy link
Contributor

xorima commented Jun 4, 2020

after merge about 10 mins if myself or another board member.

I don't like waiting for the change to go live.

@xorima xorima added Help Wanted Assistance is required to resolve this issue and removed Feature Request labels Jun 4, 2020
@MarkGibbons MarkGibbons self-assigned this Jul 24, 2020
@MarkGibbons
Copy link
Member

Could you explain what you mean by activate a resource? I've mostly seen activate used with regard to virtual environments. The resource does a pyenv init, but so does the installed pyenv.sh script in /etc/profile.d. It's not clear what is wanted here.

@xorima
Copy link
Contributor

xorima commented Jul 27, 2020

My guess @MarkGibbons is that creation of a python environment and activation of that virtual env should be split in some form?

@tilne Can you confirm if I am inline with what you want?

@ramereth ramereth added the hacktoberfest An issue highlighted for the digital ocean Hacktoberfest Event label Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest An issue highlighted for the digital ocean Hacktoberfest Event Help Wanted Assistance is required to resolve this issue
Projects
None yet
Development

No branches or pull requests

4 participants