Build: Separate test and production build steps #6123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RXminuS
changed the title
jamesmcnamara
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the agent tests would invoke a build during the tests. This would cause issues on slow execution environments (e.g. Windows CI builds) where builds would try to overwrite files that were in use by other tests.
Now we ensure that the build happens before the tests are executed and never during the testing.
Test plan
Tests should pass. No new functionality
To test yourself simply eliminate all prior builds, run
pnpm run build:for-testsandpnpm run test:unit(which is what the CI pipeline runs)