wip: cache site version info to avoid redundant requests #6048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a cache for the site version to avoid redundant requests to the Sourcegraph API. The cache is cleared when the server endpoint changes. The key aspects of this change are: - Maintain a `siteVersionCache` map to store the site version promise per server endpoint - Subscribe to config changes to clear the cache when the server endpoint changes - Fetch the site version from the cache if available, otherwise make the API request and store the promise in the cache
This change introduces a cache for the site version information to avoid redundant requests to the Sourcegraph API. The cache is cleared when the server endpoint changes. The key aspects of this change are: - Maintain a `versionInfo` property to store the site version information promise per server endpoint - Fetch the site version information from the cache if available, otherwise make the API request and store the promise in the cache - Expose a `getVersionInfo` method to retrieve the cached or fetched site version information - Update the `isSiteVersionValid` method to use the cached version information
abeatrix
changed the title
DashaBochkar
approved these changes
Nov 2, 2024
DashaBochkar
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cache site version info to avoid redundant requests
This change introduces a cache for the site version information to avoid redundant requests to the Sourcegraph API. The cache is cleared when the server endpoint changes.
The key aspects of this change are:
versionInfoproperty to store the site version information promise per server endpointgetVersionInfomethod to retrieve the cached or fetched site version informationisSiteVersionValidmethod to use the cached version informationThe benefits of this approach:
Single source of truth for version information
Cleaner cache invalidation logic
Fewer API calls
More efficient version checking
Simpler code maintenance
Consistent version information across all methods
Test plan
Check the output channel to see if we are sending request for getting site version
Changelog