Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor testing set up #81

Open
YaleChen299 opened this issue Jul 27, 2023 · 1 comment
Open

Refactor testing set up #81

YaleChen299 opened this issue Jul 27, 2023 · 1 comment
Assignees

Comments

@YaleChen299
Copy link
Contributor

YaleChen299 commented Jul 27, 2023

In #80, the set-up relies on relative paths for the env file and the migration files. This may make it less maintainable in the future. To be refactored to remove this dependency on relative paths.

Moreover, the destination for the env file and migration files needs to be reiterated everywhere it is used, which is undesirable.

@RichDom2185
Copy link
Member

Furthermore, there is quite a bit of code duplication between the DB scripts and test framework. We will need to investigate how this is usually done in other Golang codebases out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants