Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port the missing branch for ConstantDynamic #1102

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Port the missing branch for ConstantDynamic #1102

merged 3 commits into from
Oct 10, 2024

Conversation

Momo-Not-Emo
Copy link
Contributor

AsmMethodSource#toSootValue

see Issue #983

swissiety
swissiety approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@swissiety swissiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for your contribution! Do you have an input example, where the added code is executed?

@Momo-Not-Emo
Copy link
Contributor Author

Thx for your contribution! Do you have an input example, where the added code is executed?

I ran the test cases included in Soot's AsmMethodSourceTest with coverage analysis. However, none of the test cases covered the code in this branch.

@swissiety swissiety merged commit 2d937ee into soot-oss:develop Oct 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissiety swissiety swissiety approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Momo-Not-Emo @swissiety