Jimple goto statement is missing

[75ACOL]

class Foo6 {
    public static void main(String[] args) {
        if (Boolean.valueOf(args[0])) {
            String name = args[1];
        } else {
            System.out.println("testMy");
        }
    }
}

{
    java.io.PrintStream $r4;
    java.lang.Boolean $r2;
    java.lang.String[] $r0, $r1, $r3;


    $r0 := @parameter0: java.lang.String[];
    $r1 = $r0[0];
    $r2 = staticinvoke <java.lang.Boolean: java.lang.Boolean valueOf(java.lang.String)>($r1);

    if $r2 == 0 goto label1;
    $r3 = $r0[1];

    goto label2;

  label1:
    $r4 = <java.lang.System: java.io.PrintStream out>;
    virtualinvoke $r4.<java.io.PrintStream: void println(java.lang.String)>("testMy");

  label2:
    return;
}

I'd like to have

{
    java.io.PrintStream $r4;
    java.lang.Boolean $r2;
    java.lang.String[] $r0, $r1, $r3;


    $r0 := @parameter0: java.lang.String[];
    $r1 = $r0[0];
    $r2 = staticinvoke <java.lang.Boolean: java.lang.Boolean valueOf(java.lang.String)>($r1);

    if $r2 == 0 goto label1;
    $r3 = $r0[1];

    goto label2;

  label1:
    $r4 = <java.lang.System: java.io.PrintStream out>;
    virtualinvoke $r4.<java.io.PrintStream: void println(java.lang.String)>("testMy");

  // Add goto label here
   goto label2;


  label2:
    return;
}

[JonasKlauke]

there is no goto needed after the code in the else branch. The next statement will be the return. A goto is only needed if you want to jump over other instructions.

[75ACOL]

class Foo {
    public static void main(String[] args) {
        if (Boolean.valueOf(args)) {
            String name = args[0];
        } else {
            System.out.println("testMy");
        }
        
        if (!args[0].startsWith("word1")) {
            args[0].replace("word1", "s");
        }
    }
}

Thank you for your reply. If I don't have an else label, how do I know what the next statement for esle is?

[JonasKlauke]

This is the bytecode of your example:

 0: aload_0
1: iconst_0
2: aaload
3: invokestatic  #7                  // Method java/lang/Boolean.valueOf:(Ljava/lang/String;)Ljava/lang/Boolean;
6: invokevirtual #13                 // Method java/lang/Boolean.booleanValue:()Z
9: ifeq          19
12: aload_0
13: iconst_0
14: aaload
15: astore_1
16: goto          27
19: getstatic     #17                 // Field java/lang/System.out:Ljava/io/PrintStream;
22: ldc           #23                 // String testMy
24: invokevirtual #25                 // Method java/io/PrintStream.println:(Ljava/lang/String;)V
27: aload_0
28: iconst_0
29: aaload
30: ldc           #31                 // String word1
32: invokevirtual #33                 // Method java/lang/String.startsWith:(Ljava/lang/String;)Z
35: ifne          49
38: aload_0
39: iconst_0
40: aaload
41: ldc           #31                 // String word1
43: ldc           #39                 // String s
45: invokevirtual #41                 // Method java/lang/String.replace:(Ljava/lang/CharSequence;Ljava/lang/CharSequence;)Ljava/lang/String;
48: pop
49: return

The program will just go down through the command list and if there is a goto it will jump to the id in the goto statement

Edit:
the ifeq jumps to 19 if it is not true
the goto in line 16 jumps over the else branch
the ifne jumps to 49 if it is true

[75ACOL]

Thank you for your reply. It's really not necessary. I'm just not used to

[JonasKlauke]

yeah no problem