-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pyproject.toml - allow higher rich version #147
Update pyproject.toml - allow higher rich version #147
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
cc @bhamail / @DarthHater please review / merge if appropriate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, +1.
Also, thanks for being persistent with the reminder pings!
Thank you @bhamail - It looks like we need an approval to release & publish to pypi. |
Doh! Yes indeed. Button mashed. Fingers crossed. |
@bhamail As I understand, versioning of jake is automated. It looks like the build tried to publish 3.0.1 again, and it failed. What's the right next step to get jake updated with the new dependency specification? |
@cshaley I tried manually incrementing the version and doing a manual release. I don't see errors in the build, but I don't see the new release in pypi either. Please ping again if nothing shows up by tomorrow. |
@bhamail - looks like no release published on PyPi - https://pypi.org/project/jake/#history or even on github https://github.com/sonatype-nexus-community/jake/releases - the semantic release step - shows no log - but on the prior step - i do see a warning on poetry-lock being out of date. That shouldn't have prevented the release.. |
@bhamail https://app.circleci.com/pipelines/github/sonatype-nexus-community/jake/1342/workflows/fbc35697-a32c-4121-a5e4-7a9049b46ac6/jobs/3072 I'm thinking the @bhamail thoughts on next steps? It looks like we could do |
@bhamail thanks for taking the next step. I think I diagnosed it. python-semantic-release has breaking changes in v8. So two options:
From reading the python-semantic-release docs linked above, I think jake's current process automatically handles version updates (i.e. v7 of semantic-release updates jake's version in github as part of the publish command). So I think we need all three lines above. |
This pull request makes the following changes:
(If there are changes to user behavior in general, please make sure to
update the docs, as well)
It relates to the following issue #s: