Support Vite 6 resolve conditions #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cd9b4fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Marked this as draft for now as I'm noticing some quirks with this approach on the svelte side. |
|
This is ready now, I'd appreciate if I can get some reviews for this as we're releasing Vite 6 soon. The breaking change fix here will also allow Astro w/ Solid to work properly in Astro's next major. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Vite 6, the top-level
resolve.conditionsonly apply to the client environment, so to apply in all environments generically, we need to use the newconfigEnvironmenthook. https://main.vite.dev/guide/migration.html#default-value-for-resolve-conditionsI adapted this change from sveltejs/vite-plugin-svelte#1020. I also remove the part where it updates the
developmentandbrowserconditions for Vite 6. I've not tested them with Vite 6, but I feel like it could interfere with the default behaviour.In practice I don't think a plugin should be modifying that. For
development, Vite should decide by itself based onNODE_ENV. Forbrowser, that seems Vitest specific and I'm not sure Vite plugins should be hardcoding Vitest specific logic.