Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A suggestion to add
reconcileWithKeys
that @katywings and I have requested in the past. In some situations you want to use reconcile with objects that have keys differently named toid
.How did you test this change?
Hehe, Im running into an issue when trying to write tests for it, when I run
npm run test
I get this error:It works in the playground, so I'm lost at to whats going on, any ideas? 🙏🏼
https://playground.solidjs.com/anonymous/9167e413-e0b2-45bf-942a-3ca2153c0416
References
https://discord.com/channels/722131463138705510/780502110772658196/971305532034011156
https://discord.com/channels/722131463138705510/780502110772658196/1278247899616247808