[Feat] 선착순 이벤트 페이지 UI 구현 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
빌드를 성공했습니다! 🎉 |
jhj2713
approved these changes
Aug 1, 2024
Comment on lines
8
to
13
| <div className="relative z-10"> | ||
| <div className="absolute top-0 left-[-38px] w-[880px] h-[390px] rounded-[29px] overflow-hidden bg-n-white/[.16] -rotate-[4deg] z-20"> | ||
| <div className="w-1/2 h-full float-left bg-gradient-green blur-[40px]" /> | ||
| <div className="w-1/2 h-full float-right bg-gradient-red blur-[40px]" /> | ||
| </div> | ||
| <div className="absolute top-0 left-[35px] w-[800px] h-[390px] rounded-[29px] overflow-hidden bg-n-white/[.16] z-5"> |
There was a problem hiding this comment.
뭔가 요 부분 태그랑 스타일만 막 나열되어있으니까 정확히 어떤 일을 하는지 파악이 안되는 것 같아용. 아예 background 역할을 하는 태그들을 따로 빼서 <...Background/> 같이 컴포넌트로 만들어서 넣어도 좋지 않을까 싶어요!
There was a problem hiding this comment.
네 좋습니다!! 제가 봐도 저게 뭔지 잘 모를 것 같긴 하네용ㅎㅎ 컴포넌트로 빼볼게요!
| import { ReactNode } from "react"; | ||
|
|
||
| interface CasperDescriptionProps { | ||
| subTitle: string | ReactNode; |
There was a problem hiding this comment.
ReactNode 타입에는 string도 포함되어있어서 이 부분은 string 빼고 ReactNode로만 해도 괜찮지 않을까요?!
There was a problem hiding this comment.
헉 그렇군요! 몰랐는데 감사합니다 :) 바로 반영할게염
|
빌드를 성공했습니다! 🎉 |
|
빌드를 성공했습니다! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖥️ Preview
2024-08-01.4.49.11.mov
✏️ 한 일
close 선착순 페이지 UI 구현 #50
❗️ 발생한 이슈 (해결 방안)
❓ 논의가 필요한 사항