Implementing Flexible Raft with NWR #1040
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(iterator):Auto commit mode for applying log iterator * feat(iterator):Auto commit mode for applying log iterator * feat(iterator):Correction parameter name * feat(iterator):mvn compile * feat(iterator):Modify comments and annotations * feat(iterator):Modify comments * feat(iterator):Modify comments * feat(rfcs):Add rfcs for Flexible-Raft-with-NWR * feat(rfcs):Add stepDown change logic and modify parameter name for rfcs * feat(rfcs):Modify factor calculation rules for rfcs * feat(rfcs):Modify some language expressions * feat(rfcs):Implementing Flexible Raft with NWR * feat(rfcs):compile project * feat(rfcs):compile project * feat(rfcs):Remove useless and redundant code * feat(rfcs):Add rfcs * feat(flexible):add flexible mode fot Jraft * feat(flexible):Modify rfc doc * feat(flexible):Modify quorum code design * feat(factor):Add ResetFactor API * feat(flexible):compile code * feat(flexible):modify code * feat(flexible):modify code * feat(flexible):compile code * fix(flexible):modify raft.desc * fix(flexible):modify MarshallerHelper * fix(flexible):modify MarshallerHelper * fix(flexible):modify RAFT.DESC * fix(flexible):Modifying comments and code formats * fix(flexible):Added factor persistence for log storage and Adapt to write heartbeat for w<r situations * fix(flexible):compile code * fix(flexible):modify test * fix(flexible):modify test * fix(flexible):modify code with proto version changing * fix(flexible):modify code with proto version changing * fix(flexible):modify code format * fix(flexible):modify code format * fix(flexible):change protoc version from 2.6.1 to 3.5.1 * fix(flexible):modify Class RaftError * fix(flexible):modify Class format * fix(flexible):modify Class format * fix(flexible):modify Class format * fix(flexible):change int64 to int32 in proto * fix(flexible):change int64 to int32 in proto * fix(flexible):avoid importing * * fix(flexible):change comment * fix(flexible):add this for voteCtx and preVoteCtx * fix(flexible):change import order * fix(flexible):change import order * feat(flexible):Place attributes such as quorum, factor, and isEnableFlexible into Configuration * feat(flexible):check format * feat(flexible):Add test code for resetFactor API * feat(flexible):modify code format * feat(flexible):enable flexible check * feat(flexible):comment useless code * feat(flexible):modify code * feat(flexible):Persisting the quorum attribute * fix(flexible):Delete redundant haveFactor judgments * fix(flexible):Add necessary null judgment * fix(flexible):remove config null parameter * fix(flexible):modify code * fix(flexible):modify some logic mistakes、remove unused method and add BallotTest * fix(flexible):modify config check * fix(flexible):modify config check * fix(flexible):remove Redundant code * fix(flexible):remove some check and add NodeOptions.setFactor method * fix(flexible):remove redundant code * fix(flexible):解决majority模式下，空指针异常问题 * fix(flexible):修改部分set quorum逻辑， * feature(flexible):添加flexible raft 测试模块 * feature(flexible):check code format * feature(flexible):remove code * feature(flexible):remove redundant blank lines * feature(flexible):modify test module * fix(LogManagerTest):modify code format * fix(LogManagerTest):modify code format * fix(LogManagerTest):modify code format * feature(flexible):modify test module in core * fix(test_core):modify test—core code * fix(test_module):modify test_core * fix(test_module):modify testTripleNodesV1V2Codec temporarily * fix(test_module):modify testTripleNodesV1V2Codec temporarily * fix(test_module):modify testTripleNodesV1V2Codec temporarily * fix(test_module):modify testTripleNodesV1V2Codec temporarily * fix(test_module):modify V1V2Codec error * fix(test_module):modify V1V2Codec error * fix(test_module):modify V1V2Codec error * fix(test_module):modify resetPeers error * fix(test_module):modify changePeerChaps test error * fix(test_module):modify v1decoder error * fix(test_module):modify v1decoder error * fix(test_module):modify storage test * fix(test_module):modify storage test * fix(test_module):modify node test * fix(test_module):modify node test * modify code * modify code * modify code --------- Co-authored-by: yuanziwei <yuanziwei@xiaohongshu.com>
|
@killme2008 hi, dennis. 我们准备好了，有时间再rv下吗？ |
|
@shihuili1218 ok，感谢 @1294566108 的努力。 有一些测试可能还需要看下。我一定在本周找个时间过下。 |
killme2008
reviewed
Dec 12, 2023
jraft-core/src/main/java/com/alipay/sofa/jraft/conf/Configuration.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/conf/Configuration.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/FSMCallerImpl.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java
Outdated
Show resolved
Hide resolved
|
What's the progress on this PR now? Is there a chance it will be included in the new version's release? #1064 |
added 14 commits
January 5, 2024 19:59
…ure/flexible_raft
|
@killme2008 The previous questions have been corrected. Are there any areas that need further correction? |
|
@1294566108 Got it, I will continue my review process, thank u. Let's finish it. |
@killme2008 Hi, do you have time to continue the code review recently? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.