axios in dependencies and peerDependencies

[parkerault]

I believe it should be one or the other, right? It generates a warning on npm install.

[dearsaturn]

I don't think it belongs in peerDependencies. That seems like a mistake.

[erhathaway]

@parkerault @dearsaturn

I think it was a mistake to be in dependencies. It would make more sense to be in devDependencies and peerDependencies. In dev, the playground uses it in the AxiosClient. In production, you can optionally use it, if you want to use the AxiosClient to submit requests.

These are the original docs I wrote on the peerDeps https://github.com/social-native/elastic-composer#peer-dependencies

[parkerault]

If I were the king of the universe I would put it in peerDependencies and log an error if AxiosESClient is imported and it's not available. There's also optionalDependencies but it gets installed by default because npm always does the opposite of what you would expect. :)

[erhathaway]

@parkerault

There's also optionalDependencies but it gets installed by default because npm always does the opposite of what you would expect. :)

I did not know about this! Very cool!

I just checked out the docs, there is also peerDependenciesMeta (https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependenciesmeta). This could be used to clean up the terminal output.

What are your thoughts about this situation? Leave as peer or try to clean up or something else?

[erhathaway]

@parkerault I'm not fully awake. Just reread what you wrote. I like the idea of logging an error if missing. I think that plus peerDependenciesMeta + devDependencies would be a good approach.