Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Sort API #15

Open
erhathaway opened this issue Feb 22, 2020 · 2 comments
Open

RFC: Sort API #15

erhathaway opened this issue Feb 22, 2020 · 2 comments

Comments

@erhathaway
Copy link
Contributor

erhathaway commented Feb 22, 2020

Initial thoughts are that it should should have methods:

  • addToSort: (fieldName: string) => void
  • incrementSortOrder: (fieldName: string) => void
  • decrementSortOrder: (fieldName: string) => void
  • order: { [fieldName: string]: number } // number is 1+
  • removeFromSort: (fieldName: string) => void

Also, sort should be an object accessible from the manager

@mattweg-zz
Copy link
Contributor

Are ordering and sorting synonymous?

@erhathaway
Copy link
Contributor Author

Ah yes they are. Sort is probably a better name. I can change that

@erhathaway erhathaway changed the title RFC: Order API RFC: Sort API Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants