Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1619616: Failing tests of [Small|Big|]IntToScaledFixedConverter for non-standard LOCALE #1867

Open
bauer-at-work opened this issue Aug 9, 2024 · 0 comments
Assignees
Labels
bug status-triage Issue is under initial triage

Comments

@bauer-at-work
Copy link

bauer-at-work commented Aug 9, 2024

  1. What version of JDBC driver are you using?
    latest from git

  2. What operating system and processor architecture are you using?
    Fedora 40, amd64

  3. What version of Java are you using?
    21

  4. What did you do?
    ./mvnw clean verify

  5. What did you expect to see?

    all test successful.
    However, three tests (SmallInt, Int, BigInt conversion) were failing.

For example,

test IntToFixedConverterTest::testFixedWithScale()

Test run with standard system settings

L130 converter.toString(i): Here, a value in the form of 1,234 is returned.

L141 expectedVal.toString(): This returns 1.234.

Test run with LC_ALL=C

Test completes successfully

SUMMARY

the [Small|Big|]IntToScaledConvert classes are not locale-agnostic and run into failures depending on the locale configuration of the system.

I believe that either

  • the tests should take the locale into account
  • there should be new tests that assert correct handling of locale settings
  • the README or developer notes should mention to run with LC_ALL=C or something along those lines
@github-actions github-actions bot changed the title Failing tests of [Small|Big|]IntToScaledFixedConverter for non-standard LOCALE SNOW-1619616: Failing tests of [Small|Big|]IntToScaledFixedConverter for non-standard LOCALE Aug 9, 2024
@sfc-gh-wfateem sfc-gh-wfateem self-assigned this Sep 10, 2024
@sfc-gh-wfateem sfc-gh-wfateem added the status-triage Issue is under initial triage label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug status-triage Issue is under initial triage
Projects
None yet
Development

No branches or pull requests

2 participants