Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul health displaying #105

Open
snollygolly opened this issue Jun 11, 2019 · 3 comments
Open

Overhaul health displaying #105

snollygolly opened this issue Jun 11, 2019 · 3 comments

Comments

@snollygolly
Copy link
Owner

When you purchase health from the health vendor, you increase your current health, but also your max health. That means that the existing handlebars helper for calculating the "friendly" health description (you are feeling not so great) probably won't work as players reach the end game.

@jiaming10
Copy link
Contributor

Do you think it make sense to calculate based on percentage? So the current logic will be convert to this instead:

100% Perfect Health
75% Pretty Good
50% Not So Great
25% Pretty Terrible

@snollygolly
Copy link
Owner Author

Yeah, I think that makes a lot of sense. 👍

@jiaming10
Copy link
Contributor

Looking at the description at full health, the sentence you're feeling in perfect health. feels a bit weird.

And so I have another idea. The description will be as following:

100% you're feeling perfect.
80% you're feeling great.
75% you're feeling pretty good
50% you're feeling not so great
25% you're feeling terrible
10% you're feeling extremely exhausted

Added some conditions so that it feels more lively.

Please let me know what are your thoughts on this, as well as the wordings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants