Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new privacy type #954

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

feat: add new privacy type #954

wants to merge 7 commits into from

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Oct 31, 2024 •
edited
Loading

Summary

  • Adds new option in space settings to select "any" privacy type
  • Adds new option on proposal editor to enable/disable shielded voting
  • Adds new option on update proposal editor to enable/disable shielded voting

Closes: https://github.com/snapshot-labs/workflow/issues/277

How to test

  1. Go to your settings, under Privacy - you should see the new option "any"
    image
  2. Inside proposal editor, you should see new option
    image
image

To-Do

  • Need to update and test with backend (In review)

@ChaituVR
Copy link
Member Author

Comments:

  • Default to Any
  • Any should be the first option in the list

@ChaituVR ChaituVR mentioned this pull request Nov 4, 2024
Open
@bonustrack
Copy link
Member

Just tested and the design looks good

@ChaituVR ChaituVR changed the title [Design check] feat: add new privacy type feat: add new privacy type Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @bonustrack