Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: privacy field in proposal data #467

Merged
merged 9 commits into from
Nov 30, 2024
Merged

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Oct 29, 2024

Towards https://github.com/snapshot-labs/workflow/issues/277

Summary

  • Accept privacy field if space's privacy is any
  • Else use space's privacy as default value
  • Reject if proposal has privacy and space is not using 'any'

How to test:

src/writer/proposal.ts Outdated Show resolved Hide resolved
@ChaituVR ChaituVR marked this pull request as ready for review November 4, 2024 10:50
@ChaituVR ChaituVR marked this pull request as draft November 4, 2024 10:51
@ChaituVR ChaituVR marked this pull request as ready for review November 29, 2024 08:20
@ChaituVR ChaituVR requested a review from wa0x6e November 29, 2024 08:21
Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ChaituVR ChaituVR merged commit beb8630 into master Nov 30, 2024
1 of 2 checks passed
@ChaituVR ChaituVR deleted the add-privacy-in-proposal branch November 30, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants