Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add lint rule to enforce camelCase event name #25

Merged
merged 2 commits into from
Aug 1, 2024
Merged

fix: Add lint rule to enforce camelCase event name #25

merged 2 commits into from
Aug 1, 2024

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Jul 31, 2024 •
edited
Loading

Summary:

  • Add new rule to enforce camelCase event name

Closes #24

How to test:

  • Go to any project, for example, in mono repo, edit package.json,
  • Under eslintConfig add config from this PR (add double quotes)
  • Try to change event to kebab case
  • see error
  • Untitled 4

TODO:

  • Run yarn release to update versions, before merging this PR

@ChaituVR ChaituVR requested review from wa0x6e and Sekhmet July 31, 2024 16:44
Sekhmet
Sekhmet approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@Sekhmet Sekhmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

wa0x6e
wa0x6e approved these changes Aug 1, 2024
View reviewed changes
Copy link

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ChaituVR ChaituVR merged commit 1db3860 into master Aug 1, 2024
2 checks passed
@ChaituVR ChaituVR deleted the vue-custom-event-name-casing branch August 1, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sekhmet Sekhmet Sekhmet approved these changes

@wa0x6e wa0x6e wa0x6e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add lint to enforce camelCase event name
3 participants
@ChaituVR @wa0x6e @Sekhmet