Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SteamAchievement.is_unlocked is unnecessarily costly #4

Open
smiley opened this issue Dec 6, 2013 · 0 comments
Open

SteamAchievement.is_unlocked is unnecessarily costly #4

smiley opened this issue Dec 6, 2013 · 0 comments
Assignees

Comments

@smiley
Copy link
Owner

smiley commented Dec 6, 2013

"is_unlocked" fetches the entire achievement unlocks list for its game, then only uses its own value. While this value is then cached (so the same achievement's status doesn't change as long as the achievements list isn't re-fetched), asking another achievement the same thing will cause unnecessary slowdowns.

There needs to be a way to fetch achievements for an entire game, not through the game object itself. Maybe two-way binding is the right solution, but that might screw up garbage collection.

@ghost ghost assigned smiley Dec 6, 2013
@smiley smiley removed the critical label Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant