Check formatting of Hack + go code in our CI #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a script to check that hackfmt was ran at the root of the repository. It seemed more useful to fold the logic into the CI so it is automatically checked. The formatting changes are whitespace only.
jchaffraix-slack
force-pushed
the
julien_format_in_ci
branch
from
1fe7754
to
d121435
Compare
| @@ -146,10 +146,10 @@ func mustFullyQualified(fqn string) { | |||
| } | |||
|
|
|||
| // Find is where the magic happens. It takes a fully qualified proto name | |||
| // e.g. ".foo.bar.baz" | |||
There was a problem hiding this comment.
This was a tab that confused go fmt so better to remove it.
henryr
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a script to check that hackfmt was ran
at the root of the repository. It seemed more
useful to fold the logic into the CI so
it is automatically checked.
The formatting changes are whitespace only.