Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making selectors public #1146

Open
3 tasks
TheooJ opened this issue Nov 19, 2024 · 2 comments
Open
3 tasks

Making selectors public #1146

TheooJ opened this issue Nov 19, 2024 · 2 comments
Labels
discussion Something somewhat open-ended to discuss meta-issue Lists a bunch of tasks

Comments

@TheooJ
Copy link
Contributor

TheooJ commented Nov 19, 2024

In #1116, we discussed allowing users to use skrub selectors for the cols parameter. Selecting columns is very frequent in skrub transformers, and they might be useful for users. They are currently private, if we want to render them public, we need to:

  • Document them. Their docstrings are already quite exhaustive but we need a dedicated example / reference in the doc
  • Define for which parameters / transformers we allow selectors
  • Support them in those cases (Joiner, AggJoiner, MultiAggJoiner, SelectCols, DropCols, TableVectorizer, etc)
@TheooJ TheooJ added meta-issue Lists a bunch of tasks discussion Something somewhat open-ended to discuss labels Nov 19, 2024
@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented Nov 19, 2024 via email

@TheooJ
Copy link
Contributor Author

TheooJ commented Nov 19, 2024

Fair enough, let's see how this develops then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Something somewhat open-ended to discuss meta-issue Lists a bunch of tasks
Projects
None yet
Development

No branches or pull requests

2 participants