Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance logs readability per exchange #445

Open
sjanel opened this issue Aug 11, 2023 · 0 comments
Open

Enhance logs readability per exchange #445

sjanel opened this issue Aug 11, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@sjanel
Copy link
Owner

sjanel commented Aug 11, 2023

Currently the logs don't always specify which exchange they are related to.
It's sometimes difficult to understand what's happening especially with the coming support of parallel requests.

What about adding a sub subject with the ExchangeName in spdlog ?

For instance, from this (currently):

[2023-08-11 17:54:46.358] [info] GET https://api.upbit.com/v1/accounts
[2023-08-11 17:54:46.358] [info] GET https://api.kucoin.com/api/v1/accounts

to something like:

[2023-08-11 17:54:46.358] [info] [upbit_marc] GET https://api.upbit.com/v1/accounts
[2023-08-11 17:54:46.358] [info] [kucoin_brian] GET https://api.kucoin.com/api/v1/accounts
@sjanel sjanel added the enhancement New feature or request label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant