Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EventTarget when targeting Node.js 20 #162

Open
Richienb opened this issue Feb 1, 2022 · 5 comments
Open

Use EventTarget when targeting Node.js 20 #162

Richienb opened this issue Feb 1, 2022 · 5 comments
Labels
enhancement help wanted

Comments

@Richienb
Copy link
Collaborator

Richienb commented Feb 1, 2022 •
edited
Loading

EventTarget is a built-in way to do events in Node.js 16+. This could be used instead of eventemitter3 when Node.js 14 is EOL.
@sindresorhus sindresorhus changed the title EventTarget Use EventTarget when targeting Node.js 14 Feb 1, 2022
@Richienb Richienb changed the title Use EventTarget when targeting Node.js 14 Use EventTarget when targeting Node.js 16 May 26, 2022
@sindresorhus
Copy link
Owner

This can be done now.

@Richienb
Copy link
Collaborator Author

nevermind https://nodejs.org/api/events.html#class-customevent

@Richienb Richienb changed the title Use EventTarget when targeting Node.js 16 Use EventTarget when targeting Node.js 18 Aug 30, 2023
@Richienb
Copy link
Collaborator Author

waiting for CustomEvent to go stable on node

@Richienb
Copy link
Collaborator Author

CustomEvent exposed in globals on v19 nodejs/node#44860
I think new globals is semver major so might not be backported...?

@Richienb Richienb changed the title Use EventTarget when targeting Node.js 18 Use EventTarget when targeting Node.js 20 Dec 11, 2023
@Richienb
Copy link
Collaborator Author

Richienb commented Jul 2, 2024

Node.js 18 will be EOL April 2025. So, we should make this change by sometime early 2025.

@Richienb Richienb pinned this issue Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @Richienb