Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

globby async variant does not work on windows. #152

Open
lukasholzer opened this issue Sep 9, 2020 · 4 comments
Open

globby async variant does not work on windows. #152

lukasholzer opened this issue Sep 9, 2020 · 4 comments

Comments

@lukasholzer
Copy link

If I use the globby.sync it is working on windows. The globby default export (async) variant is returning an empty [].

const globby = require('globby');

const globList = ["path/to/files/*", "other/path/*"];

const files = globby.sync(globList))
// files has all items

globby(globList).then((asyncFiles) => {
// asyncFiles is an empty []
})

environment

  • version: 11.0.0
  • os: windows 10
  • node: 14.9.0
@alinnert
Copy link

This seems to be working in 13.1.2. I've tested both sync and async on Windows 10 22H2, Node 14.20.1. I figured out you only have to make sure to use / in your path, no \. Especially if you use functions like path.resolve().

@fisker
Copy link
Collaborator

fisker commented Nov 17, 2022

This should have been fixed, we have tests on Windows.

@fisker fisker closed this as completed Nov 17, 2022
@Jordloop
Copy link

Jordloop commented Dec 7, 2022

I am also having this same issue. I've done a bit of testing and believe I may have found an edge case.

I have two identical file structures. One is in C:/Program Files, the other is in C:/Program Files (x86)

I get an empty [] when targeting anything in Program Files (x86).

image

image

image

image

version: 13.1.2
os: windows 10
node: 14.9.0

@fisker fisker reopened this Dec 7, 2022
@dev-harrisonw
Copy link

Any update on this issue? Async still doesn't work :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants