Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path xxxAtTime functions assume segments are equal length #11

Open
dustismo opened this issue Jan 21, 2021 · 3 comments
Open

path xxxAtTime functions assume segments are equal length #11

dustismo opened this issue Jan 21, 2021 · 3 comments

Comments

@dustismo
Copy link

Hello,

First of all, thank you for this library! I am using to reimplement (heavyfishdesign.com) in python.

I believe I have come across a bug, (or at least an undocumented assumption).

def pointAtTime(self,t):

Seems to assume that each segment along the path is equally spaced. for instance the path:

M 0.000 0.000 L 1.000 0.000 L 2.000 0.000 L 3.000 0.000 L 10.000 0.000

at t= .7 yields 2.8

Thanks again, and I can probably fix it and do a PR, but wanted to make sure I am not misunderstanding the intent of these methods

@simoncozens
Copy link
Owner

Hi! Good to hear that the library is being useful for you! Yeah, that definitely looks like a bug. If you're happy to fix and PR I'd be very happy to merge it. Thanks!

@dustismo
Copy link
Author

Ok, great. Additionally: test_path.py fails for me from master, is that expected? I can work through it, but I'm trying to figure out if it is my environment or something else.

@dustismo
Copy link
Author

Looks like the precision change in _curve_curve_intersections_t broke various tests. From my understanding so far, it seems that the lower precision is causing 2X the number of intersections. I'm still looking for the cause

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants