Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone link validation and display helpers? #252

Open
GuySartorelli opened this issue Mar 13, 2024 · 2 comments
Open

Phone link validation and display helpers? #252

GuySartorelli opened this issue Mar 13, 2024 · 2 comments

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Mar 13, 2024

I came across this while looking into the migration path from gorriecoe/silverstripe-link.

That module uses giggsey/libphonenumber-for-php to provide some template helpers for phone number formatting.

That library also provides some validation functionality and seems both very robust and well maintained.

Do we want to add one or both of:

  1. Phone number formatting helpers
  2. Phone number validation
@maxime-rainville
Copy link

My instinct would be to create an optional PhoneField and ship it an optional unsupported module. If there's legitimate interest in this, we can brig it back into core at a later date.

@GuySartorelli
Copy link
Member Author

I would be hesitant to include an optional unsupported module as a dependency of a supported module...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants