API Use dynamic config for ModalController forms #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Nov 25, 2024
| const sectionConfigKey = 'SilverStripe\\CMS\\Controllers\\CMSPageEditController'; | ||
| const sectionConfigKey = 'SilverStripe\\Admin\\LeftAndMain'; |
There was a problem hiding this comment.
LeftAndMain now dynamically lists all link forms registered with ModalController.link_modal_form_factories
These do get inherited, so CMSPageEditController would still work, but it seems sensible to use the more generic controller here (especially since CMSPageEditController is not long for this world)
GuySartorelli
commented
Nov 25, 2024
Comment on lines
-46
to
-51
| 'editorInternalLink' => [ | ||
| 'schemaUrl' => $modalController->Link('schema/editorInternalLink'), | ||
| ], | ||
| 'editorAnchorLink' => [ | ||
| 'schemaUrl' => $modalController->Link('schema/editorAnchorLink/:pageid'), | ||
| ], |
There was a problem hiding this comment.
These get included in LeftAndMain::getClientConfig() now instead.
GuySartorelli
commented
Nov 25, 2024
| $pageIDField->setValue((int)$context['PageID']); | ||
| $pageIDField->setValue((int)$context['ItemID']); |
There was a problem hiding this comment.
This was changed to be more generic so we can reuse it in other link forms if needed.
3 tasks
GuySartorelli
force-pushed
the
pulls/6/modal-controller
branch
from
21bf47a
to
1738a21
Compare
GuySartorelli
force-pushed
the
pulls/6/modal-controller
branch
from
1738a21
to
a760dfe
Compare
emteknetnz
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant extension in favour of new functionality in ModalController
Relies on changes in silverstripe/silverstripe-admin#1860
Issue
ModalControllersilverstripe-admin#1765