Fix TinyMCE edit link when link contains html #2993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
satrun77
changed the title
satrun77
force-pushed
the
pull/edit-link-tinymce
branch
from
35a7fd0
to
799ebc0
Compare
GuySartorelli
requested changes
Aug 21, 2024
Comment on lines
+125
to
+131
| if (linkNode.nodeName !== 'A') { | ||
| let count = 0; | ||
| while (count < 10 && linkNode.parentNode && linkNode.nodeName !== 'A') { | ||
| linkNode = linkNode.parentNode; | ||
| count +=1; | ||
| } | ||
| } |
There was a problem hiding this comment.
Please don't use a while loop - especially with a completely arbitrary number of iterations. If there's a function available to recursively check the ancestors of the element, use that. Otherwise, this might need to go back to the drawing board.
| @@ -119,7 +119,17 @@ jQuery.entwine('ss', ($) => { | |||
|
|
|||
| getOriginalAttributes() { | |||
| const editor = this.getElement().getEditor(); | |||
| const node = $(editor.getSelectedNode()); | |||
|
|
|||
| // Find "a" node, issue https://github.com/silverstripe/silverstripe-cms/issues/2439 | |||
There was a problem hiding this comment.
Suggested change
| // Find "a" node, issue https://github.com/silverstripe/silverstripe-cms/issues/2439 | |
| // Try to find a parent <a> tag in case the user clicks on some child node inside a link |
|
No longer needed! The fix in silverstripe/silverstripe-admin#1814 fixes the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you have a link in tinymce like
<a href=""><span>Title</span></a>, then you can edit the link. The HTML inside the link tag can be any tag.The issue is that the selected node is the inside HTML tag instead of the link tag.
I'm not 100% keen on the solution using
whilebut this is legacy code, so might be ok! Alternative code is welcomed :)This PR is needed for silverstripe/silverstripe-admin#1814
Manual testing steps
Issues
Pull request checklist