Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nov 2024 - Update third party JS deps #308

Closed
3 tasks
emteknetnz opened this issue Sep 3, 2024 · 1 comment
Closed
3 tasks

Nov 2024 - Update third party JS deps #308

emteknetnz opened this issue Sep 3, 2024 · 1 comment

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Sep 3, 2024

The CMS 6 beta will be released around mid Jan 2025. Upgrading the JS dependencies should be done fairly close to this cut-off to allow as much time for third party new major versions to be released, though still allow some time to ensure we have adequate time to upgrade everything.

Acceptance criteria

  • JS dependencies that should be upgraded to new major versions are identified
  • JS dependencies are upgraded
  • New cards are created based on comment

Notes

  • PRs are just running yarn upgrade + yarn build on all modules that have a package.json to minor upgrade them in preparation for bumping major versions of JS deps to reduce chance of upgrade issues
  • https://github.com/emteknetnz/js-upgrader was used to automate lots of this

New issues created

Kitchen sink CI for minor update PRs

PRs - minor updates only

@GuySartorelli GuySartorelli added this to the Silverstripe CMS 6.0 milestone Sep 13, 2024
@emteknetnz emteknetnz self-assigned this Nov 18, 2024
This was referenced Nov 18, 2024
@emteknetnz
Copy link
Member Author

emteknetnz commented Nov 18, 2024

Major deps to update, probably makes sense to have separate cards for different deps and combine there is a commonality e.g. bootstrap + reactstrap, and have have an 'other' card for everything else

Dependencies

  • bootstrap + reactstrap
  • redux / redux-thunk / react-redux
  • tinymce
  • react-dnd / react-dnd-html5-backend
  • uuid / griddle-react / regenerator-runtime / qrcode.react / query-string

Dev-dependencies

  • storybook
  • testing-library/react
  • copy-webpack-plugin / html-loader / babel-jest / jest-cli / css-loader / eslint / @silverstripe/webpack-config

Ignore the deps for silverstripe/documentation-lint

Note that immutable in silverstripe/admin was locked to ^4 - explanation

bootstrap => 5.3.3
  silverstripe/admin
  silverstripe/asset-admin
  silverstripe/campaign-admin
  silverstripe/cms
  silverstripe/linkfield
  silverstripe/login-forms
  silverstripe/versioned-admin
  dnadesign/silverstripe-elemental

react-dnd => 16.0.1
  silverstripe/admin
  silverstripe/asset-admin
  dnadesign/silverstripe-elemental

react-dnd-html5-backend => 16.0.1
  silverstripe/admin
  silverstripe/asset-admin
  dnadesign/silverstripe-elemental

react-redux => 9.1.2
  silverstripe/admin
  silverstripe/asset-admin
  silverstripe/campaign-admin
  silverstripe/cms
  silverstripe/contentreview
  silverstripe/frameworktest
  silverstripe/linkfield
  silverstripe/mfa
  silverstripe/session-manager
  silverstripe/versioned-admin
  dnadesign/silverstripe-elemental

reactstrap => 9.2.3
  silverstripe/admin
  silverstripe/asset-admin
  silverstripe/campaign-admin
  silverstripe/cms
  silverstripe/elemental-bannerblock
  silverstripe/linkfield
  silverstripe/mfa
  silverstripe/session-manager
  silverstripe/versioned-admin
  dnadesign/silverstripe-elemental
  bringyourownideas/silverstripe-maintenance

redux => 5.0.1
  silverstripe/admin
  silverstripe/asset-admin
  silverstripe/campaign-admin
  silverstripe/cms
  silverstripe/contentreview
  silverstripe/frameworktest
  silverstripe/linkfield
  silverstripe/mfa
  silverstripe/session-manager
  silverstripe/versioned-admin
  dnadesign/silverstripe-elemental

redux-thunk => 3.1.0
  silverstripe/admin
  silverstripe/asset-admin
  silverstripe/campaign-admin
  silverstripe/frameworktest
  silverstripe/linkfield

tinymce => 7.5.1
  silverstripe/admin

uuid => 11.0.3
  silverstripe/admin
  silverstripe/versioned-admin

griddle-react => 1.13.1
  silverstripe/asset-admin
  silverstripe/versioned-admin

eslint => 9.15.0
  silverstripe/documentation-lint

eslint-plugin-markdown => 5.1.0
  silverstripe/documentation-lint

markdownlint => 0.36.1
  silverstripe/documentation-lint

markdownlint-cli2 => 0.15.0
  silverstripe/documentation-lint

regenerator-runtime => 0.14.1
  silverstripe/mfa

qrcode.react => 4.1.0
  silverstripe/totp-authenticator

query-string => 9.1.1
  tractorcow/silverstripe-fluent


# Major dev deps

@storybook/addon-actions => 8.4.4
  silverstripe/admin
  silverstripe/asset-admin
  silverstripe/versioned-admin

@storybook/addon-controls => 8.4.4
  silverstripe/admin

@storybook/addon-essentials => 8.4.4
  silverstripe/admin

@storybook/addon-interactions => 8.4.4
  silverstripe/admin

@storybook/addon-links => 8.4.4
  silverstripe/admin

@storybook/blocks => 8.4.4
  silverstripe/admin

@storybook/react => 8.4.4
  silverstripe/admin
  silverstripe/versioned-admin

@storybook/react-webpack5 => 8.4.4
  silverstripe/admin

@storybook/testing-library => 0.2.2
  silverstripe/admin

@testing-library/react => 16.0.1
  silverstripe/admin
  silverstripe/asset-admin
  silverstripe/campaign-admin
  silverstripe/cms
  silverstripe/elemental-bannerblock
  silverstripe/linkfield
  silverstripe/mfa
  silverstripe/session-manager
  silverstripe/tagfield
  silverstripe/totp-authenticator
  silverstripe/versioned-admin
  silverstripe/webauthn-authenticator
  dnadesign/silverstripe-elemental

copy-webpack-plugin => 12.0.2
  silverstripe/admin
  silverstripe/asset-admin
  silverstripe/cms
  silverstripe/mfa
  silverstripe/tagfield
  silverstripe/totp-authenticator
  silverstripe/userforms
  silverstripe/webauthn-authenticator

html-loader => 5.1.0
  silverstripe/admin
  silverstripe/tagfield

storybook => 8.4.4
  silverstripe/admin

babel-jest => 29.7.0
  silverstripe/frameworktest

jest-cli => 29.7.0
  silverstripe/frameworktest

css-loader => 7.1.2
  silverstripe/login-forms

eslint => 9.15.0
  silverstripe/login-forms

@storybook/addons => 7.6.17
  silverstripe/versioned-admin

@silverstripe/webpack-config => 3.0.0-alpha2
  colymba/gridfield-bulk-editing-tools
  symbiote/silverstripe-advancedworkflow
  symbiote/silverstripe-multivaluefield
  tractorcow/silverstripe-fluent
  bringyourownideas/silverstripe-maintenance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants