Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate replacing SIL.DataAccess with EF Core #494

Open
ddaspit opened this issue Sep 16, 2024 · 2 comments
Open

Investigate replacing SIL.DataAccess with EF Core #494

ddaspit opened this issue Sep 16, 2024 · 2 comments
Assignees

Comments

@ddaspit
Copy link
Contributor

ddaspit commented Sep 16, 2024

In the last year, Mongo has released a MongoDB EF Core Provider. EF Core is the preferred data access library for ASP.NET Core. SIL.DataAccess was necessary, because there was no EF Core provider for MongoDB. Now that there is, it would probably be worth investigating replacing SIL.DataAccess altogether.

@ddaspit ddaspit added this to Serval Sep 16, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Serval Sep 16, 2024
@johnml1135
Copy link
Collaborator

https://www.mongodb.com/docs/entity-framework/current/limitations/

It appears that there are significant limitations to EF core right now, including not being able to use Select(). I see no drawback in holding off for right now until 1 or 2 more versions come out.

@johnml1135
Copy link
Collaborator

As per conversation with Damien, although we are using Select(), we are using it after we already grab the data from the database. There are no perceived issues with migrating to EF Core.

@johnml1135 johnml1135 self-assigned this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants