update docker ref to pull from GHCR image #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
haydentherapper
approved these changes
Nov 6, 2024
|
We haven’t had good luck with actions cache for the go code we rebuild but potentially if we fixed #94 we could just reuse that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cached docker images have been removed from the ubuntu24.04 image (per actions/runner-images#10636) ... so when ubuntu-latest pointer moves in December, this will break our prober.
Instead of pulling from docker hub and potentially running into rate limiting, this changes to pull from a container on GHCR which hopefully minimizes external flakes