[WIP] Modernization/migrate to smart pointers

srecord/input/filter/message/adler16.cc

@@ -56,7 +56,7 @@ srecord::input_filter_message_adler16::process(const memory &input,
     // lowest address to highest.  (Holes are ignored, not filled,
     // warning already issued.)
     //
-    memory_walker_adler16::pointer w = memory_walker_adler16::create();
+    auto  w = std::make_shared<memory_walker_adler16>();
     input.walk(w);
     uint16_t adler = w->get();
 

srecord/input/filter/message/adler32.cc

@@ -56,8 +56,8 @@ srecord::input_filter_message_adler32::process(const memory &input,
     // lowest address to highest.  (Holes are ignored, not filled,
     // warning issued already.)
     //
-    memory_walker_adler32::pointer w =
-        memory_walker_adler32::create();
+    auto w = std::make_shared<memory_walker_adler32>();
+
     input.walk(w);
     uint32_t adler = w->get();
 

srecord/memory/walker/adler16.cc

@@ -21,13 +21,6 @@
 #include <srecord/output.h>
 
 
-srecord::memory_walker_adler16::pointer
-srecord::memory_walker_adler16::create()
-{
-    return pointer(new srecord::memory_walker_adler16());
-}
-
-
 void
 srecord::memory_walker_adler16::observe(uint32_t, const void *data,
     int length)

srecord/memory/walker/adler16.h

@@ -34,27 +34,11 @@ class memory_walker_adler16:
     public memory_walker
 {
 public:
-    typedef std::shared_ptr<memory_walker_adler16> pointer;
-
     /**
       * The destructor.
       */
     ~memory_walker_adler16() override = default;
 
-private:
-    /**
-      * The default constructor.  It is private on purpose, use the
-      * #create method instead.
-      */
-    memory_walker_adler16() = default;
-
-public:
-    /**
-      * The create class method is used to create new dynamically
-      * allocated instances of this class.
-      */
-    static pointer create();
-
     /**
       * The get method is used to get the ADLER16 checksum once all memory
       * chunks have been processed by calls to our observe method.
@@ -82,6 +66,12 @@ class memory_walker_adler16:
       * The assignment operator.
       */
     memory_walker_adler16 &operator=(const memory_walker_adler16 &) = delete;
+
+    /**
+      * The default constructor.  It is private on purpose, use the
+      * #create method instead.
+      */
+    memory_walker_adler16() = default;
 };
 
 };

srecord/memory/walker/adler32.cc

@@ -21,13 +21,6 @@
 #include <srecord/output.h>
 
 
-srecord::memory_walker_adler32::pointer
-srecord::memory_walker_adler32::create()
-{
-    return pointer(new srecord::memory_walker_adler32());
-}
-
-
 void
 srecord::memory_walker_adler32::observe(uint32_t, const void *data,
     int length)

srecord/memory/walker/adler32.h

@@ -34,27 +34,11 @@ class memory_walker_adler32:
     public memory_walker
 {
 public:
-    typedef std::shared_ptr<memory_walker_adler32> pointer;
-
     /**
       * The destructor.
       */
     ~memory_walker_adler32() override = default;
 
-private:
-    /**
-      * The default constructor.  It is private on purpose, use the
-      * #create method instead.
-      */
-    memory_walker_adler32()  = default;
-
-public:
-    /**
-      * The create class method is used to create new dynamically
-      * allocated instances of this class.
-      */
-    static pointer create();
-
     /**
       * The get method is used to get the ADLER32 checksum once all memory
       * chunks have been processed by calls to our observe method.
@@ -82,6 +66,12 @@ class memory_walker_adler32:
       * The assignment operator.
       */
     memory_walker_adler32 &operator=(const memory_walker_adler32 &) = delete;
+
+    /**
+      * The default constructor.  It is private on purpose, use the
+      * #create method instead.
+      */
+    memory_walker_adler32()  = default;
 };
 
 };