Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile features using exact same dataset settings #32

Open
siemdejong opened this issue Mar 29, 2023 · 0 comments
Open

Compile features using exact same dataset settings #32

siemdejong opened this issue Mar 29, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@siemdejong
Copy link
Owner

Describe the bug
The features may not have to be compiled using exactly the same settings for the datamodule as on which the feature extractor is trained.
This is a problem, as it might perform bad on images without a mask or tiles with a different size or mpp.

To Reproduce
Steps to reproduce the behavior:

  1. Train a feature extractor
  2. Compile features with a new PMCHHGImageDataset

Desktop (please complete the following information):

  • DPAT version 4.3.2

Additional context
A solution might be to save the pytorch lightning hyperparameters with save_hyperparameters or ask for the specific config file the feature extractor trained with, and use those variables for instantiation of PMCHHGImageDataset

@siemdejong siemdejong added the bug Something isn't working label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant