Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update axios #67

Open
jayktaylor opened this issue Nov 17, 2023 · 2 comments
Open

Update axios #67

jayktaylor opened this issue Nov 17, 2023 · 2 comments

Comments

@jayktaylor
Copy link

Hey, I've been updating some dependencies across our projects and noticed that mwn still uses version ^0.25.0 of axios. The latest version for axios is 1.6.2. Several vulnerabilties have been fixed between 0.25.0 and 1.6.2, which makes it worthwhile to upgrade.

The latest version of axios is currently incompatible with mwn as-is, but may be fixed with some small code changes.
@siddharthvp
Copy link
Owner

axios-cookiejar-support probably needs to be updated as well. Looks like some of mwn's networking code (in core.ts) can be dropped as they're natively supported in axios now. Happy to review a PR.

@jayktaylor
Copy link
Author

Yeah - it seems likely that's the case. I can try and find some time in the next week to have a look into it. mwn has been very helpful for some of our tools - thanks for the work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayktaylor @siddharthvp