Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider allowing developers to choose a list of matchers #52

Open
saks opened this issue Feb 11, 2021 · 0 comments
Open

Please consider allowing developers to choose a list of matchers #52

saks opened this issue Feb 11, 2021 · 0 comments

Comments

@saks
Copy link

saks commented Feb 11, 2021

Right now it is only possible to get a feedback for a password based on all possible factors (matchers). It is essentially all or nothing.

This behaviour may not be desirable for the case when only certain matchers matter. In our case we'd like to use zxcvbn-rs for our wasm project. We found that regex dependency is just too heavy and makes our wasm file huge for no reason (it adds ~1.5MB).

I can see why certain structs like SequenceMatch are private. But I'd like to explore any reasonable ways to configure a list of matchers.

One option could be an exposure of additional API that will enable more granular control.
Another idea is to put certain matchers behind feature flags.
I'm happy to help with experiments and an implementation.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant