-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
share the shift logo to trim page size #785
Comments
the icons are also included that way. those might be small enough where embedding makes sense. ( this is where it would be nice to have a build step, so the builder could decide. not sure if hugo, or one of its plugins?, can do that. )
|
In terms of styling and accessibility, inlined SVGs are generally best (e.g. We've already separated the definition of the SVG from where it's actually used on the page, as in this (simplified) example:
However, modern browsers now also have the ability reference an external SVG file via
We need to double-check support for this, but I think it should be OK to use now. (*Double-check this, I'm not sure if this is as well-supported as external fragments.) |
(Thanks for surfacing this, I've been meaning to dig into this for a while.) |
oh, cool. i didn't know that about the accessibility issues, nor about the svg use references. ( and a reference to the mdn documentation ... ) |
the shift logo is about 15k and gets embedded into every individual page.
it'd be better i think to load that as an svg or png and share across pages.
The text was updated successfully, but these errors were encountered: