We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch any date range other than the default 10 day range, e.g. https://www.shift2bikes.org/calendar/?startdate=2024-06-28&enddate=2024-06-28 (1 day). When you press "Show additional events" it always loads 10 more days, ignoring the size of your previously requested range.
Instead, we should use the same range length for subsequent requests. Note that the pagination.next URL in the events API response does already do this, but the frontend isn't consuming that value. e.g. Response for https://www.shift2bikes.org/api/events.php?startdate=2024-06-28&enddate=2024-06-28:
pagination.next
events
{ "events": [ … ], "pagination": { "start": "2024-06-28", "end": "2024-06-28", "range": 0, "events": 13, "next": "https://shift2bikes.org/api/events.php?startdate=2024-06-29&enddate=2024-06-29" } }
(For "range": 0, see #567.)
"range": 0
The text was updated successfully, but these errors were encountered:
carrythebanner
Successfully merging a pull request may close this issue.
Fetch any date range other than the default 10 day range, e.g. https://www.shift2bikes.org/calendar/?startdate=2024-06-28&enddate=2024-06-28 (1 day). When you press "Show additional events" it always loads 10 more days, ignoring the size of your previously requested range.
Instead, we should use the same range length for subsequent requests. Note that the
pagination.next
URL in theevents
API response does already do this, but the frontend isn't consuming that value. e.g. Response for https://www.shift2bikes.org/api/events.php?startdate=2024-06-28&enddate=2024-06-28:(For
"range": 0
, see #567.)The text was updated successfully, but these errors were encountered: