Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow injection of ldapjs client and export help function #43

Open
simonecorsi opened this issue Nov 16, 2022 · 1 comment
Open

Allow injection of ldapjs client and export help function #43

simonecorsi opened this issue Nov 16, 2022 · 1 comment

Comments

@simonecorsi
Copy link
Contributor

Hey 👋

It would be nice to export useful functions like verifyUserExists and also allow injecting our own ldapjs client while defaulting to the current behavior of instantiating its own with bind.

Use cases:

  • Allow usage of this package in env where no admin user is needed to list, eg local development LDAP server;
  • Mocking the client in tests.

Is this something you may want to add here, I'll see if I can make an MR, if not I'll just fork it :)

@shaozi
Copy link
Owner

shaozi commented Nov 18, 2022

I can see it will be very useful in the testing scenario. A pull request is welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants