New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type property "regions" missing for type Holiday #79

Open

chrschae opened this issue Apr 10, 2024 · 1 comment

chrschae commented Apr 10, 2024

Hey,

I just want to remark that the property "regions" seems to be missing for the type Holiday.

In my case i noticed it when using const holiday = getHolidaysByDate(date,region) that the property "regions" is missing.

Owner

sfakir commented Jun 14, 2024

Hi @chrschae ,
I reviewed your case and added unittest in this commit to reproduce the situation:

Basically the property "regions" is set for the holiday type.
Could you give me some more information - maybe the specific holiday?

Please note: if there is no holiday found the response would be void, and then regions is not available.

Hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment